Conversation
dburkhart07
changed the title
| fontWeight="500" | ||
| gap={2} | ||
| > | ||
| {pantryNameOptions |
There was a problem hiding this comment.
What are we doing about the case where two pantries have the same name?
There was a problem hiding this comment.
This is a good question. We really have no way to differentiate between the 2 aside from the pantry id. This makes me wonder if the best solution is rather filtering by pantryIds instead of pantryNames, yet still displaying the names in the filter. Thoughts?
There was a problem hiding this comment.
I realized this is an issue with many of our filters, so I think we can hold off on a solution for now until we fix all of them
| fetchStats(); | ||
| }, [selectedPantries, selectedYears, availableYears, currentPage]); | ||
|
|
||
| const handlePantryNameFilterChange = (name: string, checked: boolean) => { |
There was a problem hiding this comment.
would be kinda nice to have a clear button for the name filter.........
There was a problem hiding this comment.
im not against this. none of our other filters have it, so if we go through with it we should put this on every single one. gonna confirm with priya.
| fontWeight="500" | ||
| gap={2} | ||
| > | ||
| {pantryNameOptions |
There was a problem hiding this comment.
I realized this is an issue with many of our filters, so I think we can hold off on a solution for now until we fix all of them
|
spoke with priya, and we decided to remove All Available Data, and just have all the years available, unselected at first, and showing all years for donations. Once years get selected, then filtering occurs. |
| Assignments, | ||
| PantryStats, | ||
| TotalStats, | ||
| CreateDonationDto, |
There was a problem hiding this comment.
imagine this isn't necessary?
3 participants
ℹ️ Issue
Closes #162
📝 Description
Made necessary backend adjustments to support frontend design:
Frontend:
✔️ Verification
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!